Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for JSExpr v1.0. #356

Closed
wants to merge 3 commits into from
Closed

Update for JSExpr v1.0. #356

wants to merge 3 commits into from

Conversation

twavv
Copy link
Member

@twavv twavv commented Nov 1, 2019

This reverses the direction of the dependency between WebIO and JSExpr (WebIO now depends on JSExpr).

@twavv twavv mentioned this pull request Dec 21, 2019
9 tasks
@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #356 into master will decrease coverage by 14.67%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #356       +/-   ##
===========================================
- Coverage    62.1%   47.42%   -14.68%     
===========================================
  Files          16       17        +1     
  Lines         599      563       -36     
===========================================
- Hits          372      267      -105     
- Misses        227      296       +69
Impacted Files Coverage Δ
src/syntax.jl 81.48% <ø> (-12.11%) ⬇️
src/WebIO.jl 77.77% <ø> (ø) ⬆️
src/jsexpr.jl 81.25% <81.25%> (ø)
src/providers/blink.jl 0% <0%> (-80%) ⬇️
src/connection.jl 28.57% <0%> (-53.58%) ⬇️
src/asset.jl 47.16% <0%> (-32.08%) ⬇️
src/messaging.jl 2.77% <0%> (-19.45%) ⬇️
src/scope.jl 54.76% <0%> (-10.72%) ⬇️
src/render.jl 27.53% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4748f0...d2a719a. Read the comment docs.

@twavv twavv closed this Dec 22, 2019
@shashi
Copy link
Member

shashi commented Dec 22, 2019

I don't like the direction reversal, ideally they should be separate packages....!!

@shashi
Copy link
Member

shashi commented Dec 22, 2019

I know sorry I should have commented earlier, missed this. We can try again later.

Also everything is broken if I move to JSExpr v1.0.1 (Interact + all its dependencies that use @js), I had to pin to v0.5.1 to get Interact to work....

@twavv
Copy link
Member Author

twavv commented Dec 22, 2019

Hmmm I remember Interact working with the latest JSExpr stuff.

Also, they are separate packages? JSExpr is now completely independent of WebIO which is what I thought we wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants