Skip to content

Conversation

aurorarossi
Copy link
Member

@aurorarossi aurorarossi commented Nov 14, 2022

Hello!
In this PR I implemented the graph alignment algorithm 1 of this paper.

Copy link

@natema natema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the generated docs with LiveServer and the $\LaTeX$ is correctly displayed.

@aurorarossi aurorarossi marked this pull request as draft January 4, 2023 10:12
@aurorarossi aurorarossi changed the title GOAT algorithm FAQ algorithm Jan 8, 2023
@aurorarossi
Copy link
Member Author

Schermata 2023-01-06 alle 00 43 32
Comparison of the objective function values computed with this Julia implementation, a Python implementation and the correct values of 40 instances of the QAP library.

@aurorarossi aurorarossi marked this pull request as ready for review January 8, 2023 17:20
gdalle
gdalle previously requested changes Jun 28, 2023
Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aurorarossi, nice PR!
My first review is mostly focused on style and good coding practices. Feel free to ignore some of the remarks, but I think writing type-generic and allocation-free code is a better paradigm in general.
Once you address these comments, I'll do a second pass on the actual content of the algorithm!

@gdalle gdalle dismissed their stale review July 11, 2023 08:10

Obsolete

gdalle
gdalle previously approved these changes Jul 11, 2023
Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @aurorarossi! Let's do the same with #7 now 💪

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch coverage: 98.78% and project coverage change: -1.22 ⚠️

Comparison is base (6e9bf5a) 100.00% compared to head (6922505) 98.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main       #6      +/-   ##
===========================================
- Coverage   100.00%   98.78%   -1.22%     
===========================================
  Files            2        4       +2     
  Lines           33       82      +49     
===========================================
+ Hits            33       81      +48     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/flow.jl 96.77% <96.77%> (ø)
src/assignment.jl 100.00% <100.00%> (ø)
src/graph_matching.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdalle gdalle merged commit 8ad5683 into JuliaGraphs:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants