-
Notifications
You must be signed in to change notification settings - Fork 5
FAQ algorithm #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the generated docs with LiveServer
and the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aurorarossi, nice PR!
My first review is mostly focused on style and good coding practices. Feel free to ignore some of the remarks, but I think writing type-generic and allocation-free code is a better paradigm in general.
Once you address these comments, I'll do a second pass on the actual content of the algorithm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @aurorarossi! Let's do the same with #7 now 💪
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
===========================================
- Coverage 100.00% 98.78% -1.22%
===========================================
Files 2 4 +2
Lines 33 82 +49
===========================================
+ Hits 33 81 +48
- Misses 0 1 +1
☔ View full report in Codecov by Sentry. |
Hello!
In this PR I implemented the graph alignment algorithm 1 of this paper.