Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Libdl loading #56

Closed
wants to merge 1 commit into from
Closed

Conversation

bicycle1885
Copy link
Member

This suppresses WARNING: Base.Libdl is deprecated, run `using Libdl` instead warnings.

@bicycle1885
Copy link
Member Author

For clarity, I started to see these warnings on Julia 0.7-beta2.

@stevengj
Copy link
Member

Probably import instead of using since we call Libdl via qualified names?

@bicycle1885
Copy link
Member Author

I think whichever will work as we can see from the CI results (Windows failure would be a noise as usual). If you adhere to the import style, I will update the pull request.

@stevengj
Copy link
Member

Actually, I'm confused, what is using Libdl here?

@bicycle1885
Copy link
Member Author

deps/deps.jl generated by BinaryProvider.jl contains code like this:

    if Libdl.dlopen_e(libblosc) == C_NULL
        error("$(libblosc) cannot be opened, Please re-run Pkg.build(\"Blosc\"), and restart Julia.")
    end

So, I think we need to import Libdl somewhere before including the file.

@stevengj
Copy link
Member

It looks like this should be fixed in BinaryProvider: JuliaPackaging/BinaryProvider.jl#89

@stevengj stevengj closed this Jul 19, 2018
@bicycle1885
Copy link
Member Author

Okay, it makes sense.

@bicycle1885 bicycle1885 deleted the fix-libdl branch July 19, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants