Use getfield instead of getproperty for performance #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #139.
For some unknown reason, Julia seems to fail to inline
getproperty
ofStreamReader
, which causes significant performance degradation as reported in #139.This change works around the problem by directly calling
getfield(reader, :ptr)
in some performance-critical functions. The performance improvement was ~20% inuniprot_sprot.xml.gz
downloaded from https://www.uniprot.org/downloads.Before:
After:
Versioninfo: