Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QuartzImageIO #384

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Remove QuartzImageIO #384

merged 2 commits into from
Mar 16, 2024

Conversation

ViralBShah
Copy link
Contributor

As discussed in JuliaIO/QuartzImageIO.jl#77

@ViralBShah
Copy link
Contributor Author

Failures on nightly are not related to this PR. I think we should be able to merge.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (b7259eb) to head (5df2454).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          10       10           
  Lines         708      708           
=======================================
  Hits          649      649           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah merged commit 91661df into master Mar 16, 2024
26 checks passed
@ViralBShah ViralBShah deleted the vs/rm-quartzimageio branch March 16, 2024 13:34
@kimikage
Copy link

kimikage commented May 16, 2024

The registry table on documentation is not updated. https://juliaio.github.io/FileIO.jl/dev/registry/#Registry-table
Maybe it would be better to generate the table automatically or add something like doctest.

Also, "on all platforms with" is no longer useful at all. We do not have a "practical" mechanism to actively select libraries according to platform and that should be the reason for removing QuartzImageIO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants