import Mmap #515
Merged
import Mmap #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add |
|
Thanks! This could also be a great opportunity to add test. Perhaps just use #512 |
|
@musm: I added a test. It needs not be disabled on windows for the moment. That of course needs to be fixed but is beyond this PR. |
|
Test seem to pass, so this is ready to go. @musm would be nice getting a release out when this is in. I have a package that broke at the point where |
|
Thank you and I have published a release |
|
Now, HDF5+Mmap works great! with Linux/Mac. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this otherwise breaks in Julia 1.0
fixes #512