-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mmap support for windows #545
Conversation
appveyor on x86 has other issues. The other ones are green. Ping @musm for review. |
@musm @timholy any objections to merging and making a release? I am requiring this in my package https://github.com/MagneticParticleImaging/MPIFiles.jl which is supposed to also work on windows. |
I plan to take a closer look this tomorrow. |
I don't really understand why |
In any case, since it wasn't working before I plan to merge this soon, since something that works even though not ideal, is better than it not working at all. @tknopp It would be good to leave some breadcrumbs for future reference, if someone wants to delve more deeply into a proper fix. |
No, if I would know that, I would have fixed it ;-) My guess is that the file handle is not compatible with what Julia requires in the But I actually don't have access to Windows, so I am not really the best to work on the original issue. I improved the documentation and this then should be good to go from my side. I would appreciate, if this could be integrated into the upcoming release. |
Fantastic thank you very much @tknopp for working on this ! |
I plan a new release very soon with this. |
This is a test to fix mmap support on windows.