Allow user to specify integer parsing type (fixes #223) #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a ParserContext object, containing the dicttype and inttype to use for parsing JSON
TotalVerb
reviewed
Nov 17, 2017
src/Parser.jl
Outdated
| keyT = dictT.parameters[1] | ||
| function parse_object(ps::ParserState, pc::ParserContext{DictType, <:Real}) where DictType | ||
| obj = DictType() | ||
| keyT = DictType.parameters[1] |
There was a problem hiding this comment.
perhaps keytype(...), although there's probably a reason we aren't already using it
There was a problem hiding this comment.
Yes, keytype(...) would be better. I suspect the code was originally written before that function existed.
TotalVerb
reviewed
Nov 17, 2017
test/parser/inttype.jl
Outdated
| @@ -0,0 +1,16 @@ | |||
| @testset for T in [Int32, Int64, Int128] | |||
| val = JSON.parse("{\"x\": 3}", inttype=T) | |||
There was a problem hiding this comment.
we usually use 4 space indents
There was a problem hiding this comment.
Right, fixed in next push
|
👍, I think this is a good idea. |
* These are unexported, internal functions, and this ordering makes more sense.
|
Thanks, @TotalVerb, I made the suggested changes, updated the README, and made some other cosmetic changes. Because of the additional, let me know if you think anything else needs to change. Otherwise, this can be squashed and merged. |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DictTypeandIntTypeto use for parsing JSONThis is a minimally invasive way of giving the user more control over parsing.
A possible extension would be to allow specifying the float format to parse (e.g.,
DecFP,Decimals,FixedPointNumbers, etc.), although this would probably require a bit more work.Edit: Addresses part of #223, although it does not implement overflow checking.