Preserve comments in output _pb.jl files from original .proto #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds code to `generate_file` to copy all the comments from the original `.proto` file into the new generated `_pb.jl` file by reading the comments fields off of the SourceCodeInfo proto. The comments mechanism is a bit confusing in the proto descriptors, so I separated out most of the newly added logic into a new file, `src/commetns.jl`. The changes in this commit were inspired by following the example of the code here (which is under the MIT license): https://github.com/pseudomuto/protokit/blob/7037620/comments.go
This was referenced Aug 17, 2022
|
Closing this PR in favor of #208. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code to
generate_fileto copy all the comments fromthe original
.protofile into the new generated_pb.jlfile byreading the comments fields off of the SourceCodeInfo proto.
The comments mechanism is a bit confusing in the proto descriptors, so I
separated out most of the newly added logic into a new file,
src/commetns.jl.The changes in this commit were inspired by following the example of the
code here (which is under the MIT license):
https://github.com/pseudomuto/protokit/blob/7037620/comments.go
Before merging: