Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate duplicate types already defined in ColorTypes.jl #734

Merged
merged 2 commits into from
Aug 26, 2018

Conversation

@juliohm
Copy link
Member Author

juliohm commented Aug 19, 2018

Restarting the build...

@juliohm juliohm closed this Aug 19, 2018
@juliohm juliohm reopened this Aug 19, 2018
@juliohm
Copy link
Member Author

juliohm commented Aug 25, 2018

Restarting build...

@juliohm juliohm closed this Aug 25, 2018
@juliohm juliohm reopened this Aug 25, 2018
@juliohm
Copy link
Member Author

juliohm commented Aug 25, 2018

Ready to merge 👍

@timholy
Copy link
Member

timholy commented Aug 25, 2018

Needs minimum bounds on ColorTypes and possibly ImageMorphology depending on why those exports are being removed.

@codecov
Copy link

codecov bot commented Aug 25, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@bdfd044). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #734   +/-   ##
=========================================
  Coverage          ?   96.01%           
=========================================
  Files             ?       10           
  Lines             ?      727           
  Branches          ?        0           
=========================================
  Hits              ?      698           
  Misses            ?       29           
  Partials          ?        0
Impacted Files Coverage Δ
src/Images.jl 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdfd044...15ce857. Read the comment docs.

@juliohm
Copy link
Member Author

juliohm commented Aug 26, 2018

Done 👍

@timholy timholy merged commit 7578c1c into JuliaImages:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants