Allow strings in DefaultContext's api_buffer #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
common
case,dump_to_buffer
creates aVector{Any}
buffer:Clang.jl/src/expr_unit.jl
Line 66 in c2c0ea3
Which is then used to mix
Expr
andString
, using the latter for comments inprint_buffer
:Clang.jl/src/expr_unit.jl
Line 27 in c2c0ea3
Unfortunately I cannot use this in
api_buffer
since it is set toVector{Expr}
only. With this tweak, I can let my rewriter function insert docstrings that will look the way I want. I know I can put docstr + function together in an expression, but that prints ugly with the at-doc macro.If you prefer I can also just make it
Vector{Union{Expr, String}}