Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #243 #244

Merged
merged 2 commits into from
Dec 23, 2019
Merged

fix #243 #244

merged 2 commits into from
Dec 23, 2019

Conversation

inkydragon
Copy link
Contributor

trying to fix #243

should I change version number to "0.10.0"

@Gnimuc
Copy link
Member

Gnimuc commented Dec 23, 2019

should I change version number to "0.10.0"

I guess not. These APIs are not exported.

@inkydragon
Copy link
Contributor Author

test failed because this pr changed libclang_api.jl

Clang.jl/test/generator.jl

Line 25 in 7f9da94

@test read(test_api_path, String) == read(api_path, String)

All tests passed locally when using new libclang_api.jl.

@Gnimuc
Copy link
Member

Gnimuc commented Dec 23, 2019

I'm going to merge this if there is no further attempt to fix Q3.

@inkydragon
Copy link
Contributor Author

Yes, just merge it.

@Gnimuc Gnimuc merged commit e9302c6 into JuliaInterop:master Dec 23, 2019
Gnimuc added a commit that referenced this pull request Jan 27, 2020
@Gnimuc
Mute the test for generator API
aab9f74 
hard to get it right after #244 got merged
Gnimuc added a commit that referenced this pull request Jan 27, 2020
@Gnimuc
Fix CI (#248)
8d86632 
* Add back missing APIs on macOS

* Mute the test for generator API

hard to get it right after #244 got merged

* Enable CIs for Julia 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexported API
2 participants
@inkydragon @Gnimuc