Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call the documentation callback, and bump version #462

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Always call the documentation callback, and bump version #462

merged 2 commits into from
Jan 6, 2024

Conversation

JamesWrigley
Copy link
Member

@JamesWrigley JamesWrigley commented Jan 5, 2024 •
edited
Loading

So this one has two commits:

  • 24decff: always call the documentation callback if it's set, with any docstring that was parsed from the header.
  • 803226d: changing the callback signature is a breaking change so I took the liberty of bumping the minor version number (hope that's alright). I also added a changelog using Changelog.jl to document the new changes in the release. This is what it looks like: image

@JamesWrigley
Always call the documentation callback if it's set
24decff 
This is useful for rewriting the documentation, for example if the node itself
has been rewritten and you want to mention that while including the original
docstring.
@JamesWrigley
Bump the version to 0.18.0 and add a changelog
803226d
@Gnimuc Gnimuc merged commit 094d9bc into JuliaInterop:master Jan 6, 2024
11 checks passed
@JamesWrigley JamesWrigley deleted the doc-callback branch January 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesWrigley @Gnimuc