-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: linux patchset #7
Conversation
🎆 |
@Keno I'm not sure if |
Yeah, there's probably some other preprocessor options to set. |
Try 69a0f28 |
#endif | ||
|
||
// TODO: use this to set triple. Right now on linux it gets x86_64-pc-linux-gnu which doesn't work with current libc++ | ||
//if (clang_compiler->getTargetOpts().Triple.empty()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the problem here? I have just pushed a change which calls Triple::normalize before passing it in. Does that fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I missed normalize, good to know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did too. I even submitted a patch to clang to fix all the triple settings, when it was pointed out to me that I had missed normalize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It almost seems like the default behavior should be normalize
and the current behavior should be called getUnhelpfulTargetTriple
.
Rebased, not much left :) (I do still have to re-link Julia against |
Yes, I do to. But now the Makefile picks up |
Ah, cool! |
Oh good, now I can segfault in Qt! 😄. I figured it makes more sense to just open this as a wip until it works and then refine it to something mergeable.
further changes from last night:
libcxxffi
in an eval'd ccall definitionRTLD_GLOBAL
for the Qt libsin Julia I also added:
because that function is otherwise C++ mangled, so could not be found.