Switch noshift substring constructor to new unannotate function
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobnissen
force-pushed
the
no_noshift
branch
from
75617bd to
914e482
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
- Coverage 68.32% 66.86% -1.46%
==========================================
Files 1 1
Lines 161 166 +5
==========================================
+ Hits 110 111 +1
- Misses 51 55 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jakobnissen
changed the title
unannotate function
|
@tecosaur this is ready for review. IIUC, there are no tests covering the functionality that the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compatibility with JuliaLang/julia#59663