-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pkg.test()
drops Preferences
#2500
Comments
Same for Pkg.build. |
We might want to do this for the sandbox used for |
It seems like adding the preferences to the
|
timholy
added a commit
to timholy/AdmissionSuite.jl
that referenced
this issue
Feb 15, 2022
JuliaLang/Pkg.jl#2500 was fixed for Julia 1.8, so revert the workaround on those versions. Also removes a test which didn't really make sense given that we adopted `merge!` semantics for preferences.
maleadt
added a commit
to maleadt/LLVM.jl
that referenced
this issue
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While attempting to move FFTW over to using
Preferences
instead of environment variables/mutating its own state to record which backend is currently in use, I have discovered thatPkg
generates a new project when running tests, and that new project drops unknown metadata. I believe the culprit is this section:Pkg.jl/src/Operations.jl
Lines 1516 to 1534 in 0fe89b1
Since users (and other packages) are storing pieces of information inside of
Project.toml
files, I think we need to preserve as much information in theProject.toml
as possible.For preferences in particular, we also need to copy any
LocalPreferences.toml
files to the temporary directory where the project is stored as well. I am currently working around this by generating an explicittest/Project.toml
, but this is obviously sub-optimal.The text was updated successfully, but these errors were encountered: