start implementing REPL test command #33
Conversation
src/Operations.jl
Outdated
| for (pkg, testfile, version_path) in zip(pkgs, testfiles, version_paths) | ||
| # TODO: Test only dependencies | ||
| info("Testing $(pkg.name) located at $version_path") | ||
| # TODO, cd to test folder (need to be careful with getting the same EnvCache |
There was a problem hiding this comment.
Pkg2 does a cd to the package test path here but we need to be careful because if we are in a path with its own Project file then this will not be respected when the EnvCache is created in the process we start below.
We could send a path to the process below pointing to the place where the current Project is located.
There was a problem hiding this comment.
We could send a path to the process below pointing to the place where the current Project is located.
Yes, that sounds like the way to do it – should be an absolute path.
| if token[1] == :pkg | ||
| if length(token) == 2 | ||
| pkg = PackageSpec(token[2]) | ||
| pkg.mode = :manifest |
There was a problem hiding this comment.
Is this correct? So that it is possible to test packages not in the Project.
src/Operations.jl
Outdated
| for (pkg, testfile, version_path) in zip(pkgs, testfiles, version_paths) | ||
| # TODO: Test only dependencies | ||
| info("Testing $(pkg.name) located at $version_path") | ||
| # TODO, cd to test folder (need to be careful with getting the same EnvCache |
There was a problem hiding this comment.
We could send a path to the process below pointing to the place where the current Project is located.
Yes, that sounds like the way to do it – should be an absolute path.
Put most of the scaffolding in place for doing
pkg> test Pakcage.What is left (to match Pkg2) is to do resolution and support test only dependencies.