Skip to content

Conversation

nalimilan
Copy link
Member

This architecture-dependent file should not be placed in datarootdir.

(This was caught by the rpmlint tool.)

This architecture-dependent file should not be placed in datarootdir.
@nalimilan
Copy link
Member Author

Ah, of course the path test fails without this file. Looks like it's going to be tricky if we want to allow running the test both from the source tree and the install path.

@vtjnash
Copy link
Member

vtjnash commented Aug 24, 2015

would it be sufficient to move this to $(private_libdir) (that would help with my jn/makefile_o branch PR anyways)? how big of an issue is this for v0.4?

@tkelman
Copy link
Contributor

tkelman commented Aug 24, 2015

I'd prefer going that route. It's a small file and worth avoiding special cases or expected failures in Base.runtests from binaries. Would need to change the path assumptions in the tests, but that's not hard.

@nalimilan
Copy link
Member Author

Yes, moving it to $(private_libdir) would be fine. It's just that the file could not be built from test/Makefile AFAICT, but instead be built when building Julia itself. Is that what you have in mind?

@vtjnash
Copy link
Member

vtjnash commented Aug 24, 2015

Is that what you have in mind?

yes

@tkelman
Copy link
Contributor

tkelman commented Aug 24, 2015

The Julia package doesn't absolutely require a C compiler to be installed, I think the only reason this was put in test/Makefile in the first place was convenience.

@staticfloat staticfloat mentioned this pull request Sep 11, 2015
@nalimilan
Copy link
Member Author

Closing in favour of #13077

@nalimilan nalimilan closed this Sep 11, 2015
@tkelman tkelman deleted the nl/libccalltest branch September 12, 2015 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants