IdDict: support deletion, and support nothing used as a key
#26839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
status:priority
|
Tests? |
|
No, that shouldn't have an affect on this |
|
I believe that's the change that caused this. |
|
No, the bug is with the subsequent line ( |
|
You're right; it was a more general problem with deletion. |
src/table.c
Outdated
| return &tab[index + 1]; | ||
| if (key != jl_nothing) | ||
| // `nothing` is our sentinel value for deletion, so need to keep searching if it's also our search key | ||
| return NULL; |
There was a problem hiding this comment.
This looks like dead code --- if tab[index + 1] == NULL then key must be nothing.
There was a problem hiding this comment.
Good point (For comparison, I put an assert here in the other function. Just didn’t realize I had converged them after exploring some alternative ways of expressing this.)
vtjnash
force-pushed
the
jn/iddict-delete
branch
from
8273676
to
d3d58b4
Compare
previously, if we deleted one key or added `nothing` as a key, we might lose some of the other entries too (until rehash) fix #26833
vtjnash
force-pushed
the
jn/iddict-delete
branch
from
d3d58b4
to
5e57c21
Compare
ararslan
pushed a commit
that referenced
this pull request
Apr 27, 2018
ararslan
pushed a commit
that referenced
this pull request
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.