Skip to content

Only print a single LoadError: prefix for nested LoadErrors during showerror #38725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2021
+1 −1
Merged

Only print a single LoadError: prefix for nested LoadErrors during showerror #38725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b098c39
fold repeated `LoadError :` prints during showerror
IanButterworth Dec 5, 2020
4671cba
Only print a single LoadError: prefix
IanButterworth Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/errorshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function showerror(io::IO, ex, bt; backtrace=true)
end

function showerror(io::IO, ex::LoadError, bt; backtrace=true)
print(io, "LoadError: ")
!isa(ex.error, LoadError) && print(io, "LoadError: ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!isa(ex.error, LoadError) && print(io, "LoadError: ")

I'm not even entirely sure that this part of the text is useful at all?

Copy link
Member Author

@IanButterworth IanButterworth Apr 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I'd go with removing LoadError: from the error show entirely if people agree. Or would that be considered to be a breaking change?

showerror(io, ex.error, bt, backtrace=backtrace)
print(io, "\nin expression starting at $(ex.file):$(ex.line)")
end
Expand Down