Add version string to sysimg triple #51830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Oct 23, 2023
| @@ -1500,7 +1500,13 @@ void jl_dump_native_impl(void *native_code, | |||
| TheTriple.setObjectFormat(Triple::COFF); | |||
| } else if (TheTriple.isOSDarwin()) { | |||
| TheTriple.setObjectFormat(Triple::MachO); | |||
| TheTriple.setOS(llvm::Triple::MacOSX); | |||
| SmallString<16> Str; | |||
| Str += "macosx"; | |||
There was a problem hiding this comment.
This platform doesn't really seem to exist anymore. The last release appears to have been 10.4. The current Apple platform is named darwin and the release numbers of it are of the kernel, so OS 10.14 would correspond to XNU release 18.
There was a problem hiding this comment.
Annoyingly ld64 still expects it
There was a problem hiding this comment.
I learnt it the hard way: JuliaPackaging/BinaryBuilderBase.jl#285
vtjnash
reviewed
Oct 23, 2023
vtjnash
added
the
status:merge me
oscardssmith
removed
the
status:merge me
KristofferC
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit abd00d0)
KristofferC
added a commit
that referenced
this pull request
Apr 22, 2024
Backported PRs: - [x] #50759 <!-- Fix outdated usage of scrubbing for log test failures --> - [x] #51830 <!-- Add version string to sysimg triple --> - [x] #53273 <!-- [REPL] Fix typo in using/import completion --> - [x] #53499 <!-- Avoid compiler warning about redefining jl_globalref_t --> - [x] #53424 <!-- yet more atomics & cache-line fixes on work-stealing queue --> - [x] #53596 <!-- build: remove extra .a file --> - [x] #53516 <!-- permit NamedTuple{<:Any, Union{}} to be created --> - [x] #53643 <!-- Bump CSL to 1.1.1 to fix libgomp bug --> - [x] #53655 <!-- Change tbaa of ptr_phi to tbaa_value --> - [x] #53391 <!-- Default to the medium code model in x86 linux --> - [x] #53809 <!-- Add missing GC_POP() in emit_cfunction --> - [x] #53961 <!-- `LazyString` in `LinearAlgebra.checksquare` error message --> - [x] #52913 <!-- Added docstring for Artifacts.jl --> - [x] #53553 <!-- typeintersect: fix `UnionAll` unaliasing bug caused by
KristofferC
removed
the
backport 1.10
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit abd00d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we want to change this to something more dynamic, but this at least avoids the warning
Fixes #51562