remove Base.memhash global #59697
Merged
remove Base.memhash global #59697
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
requested changes
Sep 30, 2025
There was a problem hiding this comment.
I want to sort out #59691 (comment) before this merges and makes the likely revert more complicated.
adienes
reviewed
Sep 30, 2025
adienes
added
deprecation
This became unsound to use even though it was preserved "to avoid breakage" in v1.13, since continuing to use it would give incorrect hash results, which could result in corrupt dictionaries. Since #59691, these broken `hash` methods can now simply be deleted as they no longer provide any value. It is hard to say whether this is technically breaking or not as a change. It causes packages to go from giving subtly wrong answers (the worst kind of wrong) to crashing in v1.13, until the offending incorrect methods are deleted.
vtjnash
force-pushed
the
jn/drop-memhash-global
branch
from
e0ce221 to
7033f56
Compare
|
The set of packages that might be broken by this PR (well, that are already broken, but will be more visibly failing) may include some of these: |
|
Thee are also a bunch of string packages that use the old hash (StringViews, InlineStrings, etc) and is now inconsistent with the String hash. |
|
Yes, those are in my search list too, but look currently blacklisted in PkgEval so it didn't get them listed here |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary✖ Packages that failed9 packages failed only on the current version.
✔ Packages that passed tests14 packages passed tests on the previous version too. ~ Packages that at least loaded1 packages successfully loaded on the previous version too. |
oscardssmith
approved these changes
Oct 3, 2025
vtjnash
added a commit
to vtjnash/CSV.jl
that referenced
this pull request
Oct 3, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
It appears that StringViews and InlineStrings were already fixed to use the private |
vtjnash
added a commit
to vtjnash/GraphQLParser.jl
that referenced
this pull request
Oct 3, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/InMemoryDatasets.jl
that referenced
this pull request
Oct 3, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/JSON3.jl
that referenced
this pull request
Oct 3, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/StrFs.jl
that referenced
this pull request
Oct 3, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/StrFs.jl
that referenced
this pull request
Oct 3, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/WeakRefStrings.jl
that referenced
this pull request
Oct 3, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/ShortStrings.jl
that referenced
this pull request
Oct 3, 2025
Add isdefined check for Base.memhash_seed to support Julia 1.13+ where Base.memhash_seed was removed. When memhash_seed is not available, use MurmurHash3 directly without the seed offset. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/StrRegex.jl
that referenced
this pull request
Oct 3, 2025
MurmurHash3 is not used directly in StrRegex, only transitively through StrBase. Remove it from the Project.toml dependencies. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vtjnash
added a commit
to vtjnash/Strs.jl
that referenced
this pull request
Oct 3, 2025
MurmurHash3 is not used directly in Strs, only transitively through StrBase, as everything related to it was removed in 77c83fc. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
sl-solution
pushed a commit
to sl-solution/InMemoryDatasets.jl
that referenced
this pull request
Oct 6, 2025
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This became unsound to use even though it was preserved "to avoid breakage" in v1.13, since continuing to use it would give incorrect hash results, which could result in corrupt dictionaries and unsound programs.
Since #59691, these broken
hashmethods can now simply be deleted as they no longer provide any value.It is hard to say whether this is technically breaking or not as a change. It causes packages to go from giving subtly wrong answers (the worst kind of wrong) to crashing in v1.13, until the offending incorrect methods are deleted.
n.b. this is expected to break several packages (notably among them, JuliaInterpreter, which has several tests specifically just for the existence of this global), which will require some ecosystem updates. The update should just be to delete the offending method (they is now redundant, undesirable, and have been giving unsafely buggy answers), but we need to do some work to identify those places and release new versions.