Skip to content

Conversation

chriselrod
Copy link
Collaborator

No description provided.

@chriselrod chriselrod enabled auto-merge (squash) July 24, 2021 02:08
@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #106 (871b1ac) into master (1f9ce87) will decrease coverage by 0.56%.
The diff coverage is 88.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   85.59%   85.03%   -0.57%     
==========================================
  Files          11       11              
  Lines         743      755      +12     
==========================================
+ Hits          636      642       +6     
- Misses        107      113       +6     
Impacted Files Coverage Δ
src/global_constants.jl 42.00% <ø> (ø)
src/block_sizes.jl 88.33% <14.28%> (-8.34%) ⬇️
src/memory_buffer.jl 70.00% <63.63%> (+1.57%) ⬆️
src/init.jl 69.56% <66.66%> (ø)
src/funcptrs.jl 97.01% <96.66%> (-0.05%) ⬇️
src/matmul.jl 90.69% <97.67%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9ce87...871b1ac. Read the comment docs.

@chriselrod
Copy link
Collaborator Author

Failures seem to be a mix of

  1. wrong answers where we can see that the printed results don't match
  2. wrong answers where printed results do match
  3. segfaults

I can't reproduce any of these problems locally.

@chriselrod chriselrod merged commit 082c694 into master Jul 26, 2021
@chriselrod chriselrod deleted the polyester branch July 26, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant