CompatHelper: bump compat for "VectorizationBase" to "0.21" #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
DilumAluthge
force-pushed
the
compathelper/new_version/2021-08-26-01-01-22-564-1134273502
branch
from
ac17c9b to
e6c91ae
Compare
|
It'll be a while before VectorizationBase 0.21 is pushed through the ecosystem. Also, splitting it apart is 3/4 done, so it might make sense to depend more directly on the relevant pieces. On the other hand, as this depends on LV, it will have to depend on the entire thing anyway. |
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 86.62% 85.03% -1.59%
==========================================
Files 11 11
Lines 755 755
==========================================
- Hits 654 642 -12
- Misses 101 113 +12
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
VectorizationBasepackage from0.20.16to0.20.16, 0.21.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.