Skip to content

Conversation

chriselrod
Copy link
Collaborator

No description provided.

@chriselrod chriselrod requested a review from DilumAluthge April 3, 2021 07:34
@DilumAluthge
Copy link
Member

Looks good. Thanks for also fixing the compat entries!

@chriselrod chriselrod enabled auto-merge (squash) April 3, 2021 07:58
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #78 (d7189cb) into master (0123f39) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   84.42%   84.60%   +0.17%     
==========================================
  Files          10       10              
  Lines         578      565      -13     
==========================================
- Hits          488      478      -10     
+ Misses         90       87       -3     
Impacted Files Coverage Δ
src/memory_buffer.jl 68.42% <ø> (+18.42%) ⬆️
src/types.jl 100.00% <ø> (ø)
src/global_constants.jl 46.66% <0.00%> (-8.89%) ⬇️
src/matmul.jl 88.67% <0.00%> (-1.14%) ⬇️
src/block_sizes.jl 96.61% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0123f39...d7189cb. Read the comment docs.

@chriselrod chriselrod merged commit 49673bc into master Apr 3, 2021
@chriselrod chriselrod deleted the membuffersarraycore branch April 3, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants