Skip to content

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented Apr 23, 2021

Adding a note to the docs on loss of performance when Octavian is combined with Base.Threads. CheapThreads and LoopVectorization are suggested as alternatives.

Adding a note to the docs on loss of performance when Octavian is combined with Base.Threads.
@chriselrod
Copy link
Collaborator

chriselrod commented Apr 23, 2021

We could add an explanation of why, but this is fine. Looks good to me.
Maybe I should make it so that tests don't rerun if no files in src or test were actually updated.

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #80 (276916a) into master (49673bc) will decrease coverage by 1.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   86.54%   84.60%   -1.95%     
==========================================
  Files          10       10              
  Lines         565      565              
==========================================
- Hits          489      478      -11     
- Misses         76       87      +11     
Impacted Files Coverage Δ
src/global_constants.jl 46.66% <0.00%> (-20.00%) ⬇️
src/matmul.jl 88.67% <0.00%> (-1.14%) ⬇️
src/block_sizes.jl 96.61% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49673bc...276916a. Read the comment docs.

@chriselrod chriselrod merged commit 9457cdb into JuliaLinearAlgebra:master Apr 23, 2021
@jlchan
Copy link
Contributor Author

jlchan commented Apr 23, 2021

We could add an explanation of why, but this is fine

Oops - just saw this. I figured the explanation was partially in the Discourse post, so I tried to keep the note concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants