Skip to content

Conversation

ericphanson
Copy link
Member

ericphanson and others added 2 commits December 17, 2021 00:47
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@57dd263). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   93.24%           
=========================================
  Files             ?        1           
  Lines             ?       74           
  Branches          ?        0           
=========================================
  Hits              ?       69           
  Misses            ?        5           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57dd263...e80b7c7. Read the comment docs.

@ericphanson
Copy link
Member Author

with recursive JSON we could do something like emit a list of stackframes and maybe you could do some analysis to see what lines are showing up the most or something over a large codebase... But probably that's generally not going to be used, and you can always just use a different key like stacktrace = jsonify(stacktrace(catch_backtrace())) or something if you do want that (for some appropriate jsonify).

@fredrikekre fredrikekre merged commit 2b55273 into JuliaLogging:master Dec 17, 2021
@ericphanson ericphanson deleted the eph/exceptions branch December 17, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants