Skip to content

Update logger_dispatch.jl #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2019
Merged

Update logger_dispatch.jl #41

merged 1 commit into from
Aug 26, 2019

Conversation

findmyway
Copy link
Contributor

fix #40

@PhilipVinc
Copy link
Member

Hey!
Sorry it took me so long but I was Away from my laptop for a long while.

It looks fine.
Only thing I don't understand is why this is necessary, as this function should always be called with a type.

@PhilipVinc PhilipVinc merged commit a8f4a27 into JuliaLogging:master Aug 26, 2019
@findmyway
Copy link
Contributor Author

findmyway commented Aug 26, 2019 •
edited
Loading

The following line indicates that logable_propertynames can accept val of any struct type (not a type)😎

https://github.com/PhilipVinc/TensorBoardLogger.jl/blob/master/src/logger_dispatch.jl#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MethodError: no method matching logable_propertynames

2 participants

@findmyway @PhilipVinc