-
Notifications
You must be signed in to change notification settings - Fork 34
Add MisclassLoss as a generalization of ZeroOneLoss #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've fixed the typo @joshday as suggested, thanks. Could you please take a second look? |
I'm gonna wait a bit to let others weigh in if they'd like, especially since multiclass losses haven't been "solved" in LossFunctions and this is a pretty new thing. |
Thank you @joshday , I appreciate the time you're putting into it. I agree that at some point we need to better handle multiclass losses. My next PR will be on adding support for categorical values from CategoricalArrays.jl I will see what I can do to at least cover this case. |
Hi @joshday, do you think someone else will provide feedback until Friday? I will start to work locally to add support for categorical arrays assuming this PR is merged. |
Hi everyone! I just wanted to drop a quick comment in case anyone is waiting for my input. That said, I have nothing to add as I am currently not working on anything julia related and simply dont have the bandwidth available to maintain this package in any way or form. So I would be very happy for Josh to make any judgements regarding this or any other PR here (if he has the time). best regards |
There was a git conflict. I'll merge this when CI goes green! |
Hi @Evizero , thank you for your contributions, it is sad news for us that you are not involved with Julia these days. You've authored so many incredibly useful packages... I hope you are doing well, and I am glad we are always crossing roads in many organisations (JuliaImages, JuliaML, ...). Thank you @joshday for merging the PR, and for considering an invitation to JuliaML along with @oxinabox, I'd be happy to contribute more actively, and evolve the packages here to address my current research. I am particularly happy with LearnBase.jl and LossFunctions.jl. Other existing initiatives for ML in Julia (excluding deep nets) aren't as nice, and so I think we can revive the work here. It deserves more attention. |
This PR replaces #119 . I appreciate if you can take a look at it and review. We need more work on this package to make it work with CategoricalArrays.jl I am afraid that maintainers are currently busy with other tasks, and I wonder how I can keep working on improvements.