Deprecate MarginLoss + SparseArray in favour of CategoricalArray #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 93.75% 93.58% -0.17%
==========================================
Files 11 10 -1
Lines 560 546 -14
==========================================
- Hits 525 511 -14
Misses 35 35
Continue to review full report at Codecov.
|
juliohm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a single method with
MarginLossandSparseArraysthat is hanging in the codebase as a workaround for categorical representations. The plan is to think more carefully about an API withCategoricalArraysmoving forward. This new API should be more explicit about encoding/decoding schemes, possibly avoiding this memory-hungry full one-hot encoding.