Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SciML style formatter to MLDatasets.jl #205

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

Dsantra92
Copy link
Collaborator

Closes #202

@Dsantra92 Dsantra92 marked this pull request as ready for review January 18, 2023 09:39
@CarloLucibello
Copy link
Member

I don't expect any surprises, but can you also run the tests locally?

@Dsantra92
Copy link
Collaborator Author

I will run the tests at the end of the day.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #205 (3d1e300) into master (42e6f5e) will increase coverage by 0.07%.
The diff coverage is 47.03%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   48.94%   49.02%   +0.07%     
==========================================
  Files          45       45              
  Lines        2278     2299      +21     
==========================================
+ Hits         1115     1127      +12     
- Misses       1163     1172       +9     
Impacted Files Coverage Δ
src/MLDatasets.jl 100.00% <ø> (ø)
src/containers/hdf5dataset.jl 0.00% <0.00%> (ø)
src/containers/jld2dataset.jl 0.00% <0.00%> (ø)
src/containers/tabledataset.jl 0.00% <ø> (ø)
src/datasets/graphs/organicmaterialsdb.jl 9.25% <0.00%> (ø)
.../datasets/vision/cifar100_reader/CIFAR100Reader.jl 0.00% <0.00%> (ø)
...rc/datasets/vision/cifar10_reader/CIFAR10Reader.jl 0.00% <0.00%> (ø)
src/datasets/vision/mnist_reader/MNISTReader.jl 100.00% <ø> (ø)
src/download.jl 41.93% <0.00%> (ø)
src/require.jl 53.12% <0.00%> (-0.85%) ⬇️
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Dsantra92
Copy link
Collaborator Author

@CarloLucibello I tested the non-manual datasets. They passed without errors.

@CarloLucibello CarloLucibello merged commit d8e8196 into JuliaML:master Feb 17, 2023
adrhill added a commit to adrhill/MLDatasets.jl that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Julia formatter
3 participants