-
Notifications
You must be signed in to change notification settings - Fork 47
Use Pickle in favor of PyCall #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 29.46% 30.41% +0.94%
==========================================
Files 32 33 +1
Lines 784 799 +15
==========================================
+ Hits 231 243 +12
- Misses 553 556 +3
Continue to review full report at Codecov.
|
I vaguely remember trying to use Pickle instead of PyCall but failed for some reason, let's hope this works now |
It seems to work with unit tests, except for failing on deps of Pickle. |
I'm very in favor of dropping PyCall for the leaner Pickle.jl, but passing from julia >= 1.0 support to julia >= 1.6 is a bit too harsh. Can we get Pickle.jl to support at least julia 1.5? |
Fine. I will discuss to @chengchingwen. |
It's possible to loose the restriction (at least to 1.5). As far as I can remember, the reason that I drop 1.5 is only because 1.5 and 1.6 use different array summary format and thus break the doctest. It should be fixable. |
Now, it is loosen to v1.3. |
Thank you all for doing this! |
Can we tag a release with this? I am having some issues with PyCall which I think would be fixed by this. |
Done. |
Thanks! |
No description provided.