Skip to content

Add assertion to ProjectionPursuit #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Add assertion to ProjectionPursuit #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/transforms/eigenanalysis.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,6 @@ function revertfeat(::EigenAnalysis, newfeat, fcache)
end

function reapplyfeat(transform::EigenAnalysis, feat, fcache)
# basic checks
for assertion in assertions(transform)
assertion(feat)
end

# table as matrix
X = Tables.matrix(feat)

Expand Down
2 changes: 2 additions & 0 deletions src/transforms/projectionpursuit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ end
ProjectionPursuit(; tol=1e-6, maxiter=100, deg=5, perc=0.9, n=100, rng=Random.GLOBAL_RNG) =
ProjectionPursuit{typeof(tol),typeof(rng)}(tol, maxiter, deg, perc, n, rng)

assertions(::Type{<:ProjectionPursuit}) = [SciTypeAssertion{Continuous}()]

isrevertible(::Type{<:ProjectionPursuit}) = true

# transforms a row of random variables into a convex combination
Expand Down