Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coerce #37

Merged
merged 43 commits into from
Apr 13, 2022
Merged

Add Coerce #37

merged 43 commits into from
Apr 13, 2022

Conversation

ceferisbarov
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #37 (f196d3a) into master (d1fd5ec) will increase coverage by 0.02%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   92.67%   92.69%   +0.02%     
==========================================
  Files          17       18       +1     
  Lines         437      452      +15     
==========================================
+ Hits          405      419      +14     
- Misses         32       33       +1     
Impacted Files Coverage Δ
src/transforms.jl 97.82% <ø> (ø)
src/transforms/coerce.jl 93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1fd5ec...f196d3a. Read the comment docs.

src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/TableTransforms.jl Show resolved Hide resolved
src/transforms.jl Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
ceferisbarov and others added 10 commits April 8, 2022 17:24
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests with the Categorical scitype as well. It is more tricky to get right.

src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
ceferisbarov and others added 3 commits April 9, 2022 21:11
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
test/runtests.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
src/transforms/coerce.jl Outdated Show resolved Hide resolved
@juliohm juliohm changed the title Added Coerce transform Add Coerce Apr 11, 2022
@juliohm
Copy link
Member

juliohm commented Apr 11, 2022

@ceferisbarov we are almost there. We just need one more adjustment to this PR and also add the transform to the table of available transforms in the README.

README.md Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Apr 12, 2022

@ceferisbarov this branch has conflicts with the latest master branch. You need to resolve the conflicts in the PR before we can merge it.

README.md Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Apr 13, 2022

Thank you @ceferisbarov for the updates, it all looks good to me!

@eliascarv do you have any additional suggestion before we merge this?

@juliohm
Copy link
Member

juliohm commented Apr 13, 2022

Just saw you approved the PR @eliascarv , thank you!

@juliohm juliohm merged commit af0128a into JuliaML:master Apr 13, 2022
@ceferisbarov ceferisbarov deleted the coerce branch April 13, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants