Skip to content

Conversation

ceferisbarov
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (d1fd5ec) to head (f196d3a).
Report is 552 commits behind head on master.

Files with missing lines Patch % Lines
src/transforms/coerce.jl 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   92.67%   92.69%   +0.02%     
==========================================
  Files          17       18       +1     
  Lines         437      452      +15     
==========================================
+ Hits          405      419      +14     
- Misses         32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ceferisbarov ceferisbarov requested a review from juliohm April 6, 2022 20:16
@ceferisbarov ceferisbarov requested a review from juliohm April 8, 2022 01:37
ceferisbarov and others added 10 commits April 8, 2022 17:24
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
@ceferisbarov ceferisbarov requested a review from juliohm April 8, 2022 18:33
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests with the Categorical scitype as well. It is more tricky to get right.

ceferisbarov and others added 3 commits April 9, 2022 21:11
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
@juliohm juliohm changed the title Added Coerce transform Add Coerce Apr 11, 2022
@juliohm
Copy link
Member

juliohm commented Apr 11, 2022

@ceferisbarov we are almost there. We just need one more adjustment to this PR and also add the transform to the table of available transforms in the README.

@ceferisbarov ceferisbarov requested a review from juliohm April 12, 2022 07:15
@juliohm
Copy link
Member

juliohm commented Apr 12, 2022

@ceferisbarov this branch has conflicts with the latest master branch. You need to resolve the conflicts in the PR before we can merge it.

@ceferisbarov ceferisbarov requested a review from juliohm April 12, 2022 15:55
@juliohm
Copy link
Member

juliohm commented Apr 13, 2022

Thank you @ceferisbarov for the updates, it all looks good to me!

@eliascarv do you have any additional suggestion before we merge this?

@juliohm
Copy link
Member

juliohm commented Apr 13, 2022

Just saw you approved the PR @eliascarv , thank you!

@juliohm juliohm merged commit af0128a into JuliaML:master Apr 13, 2022
@ceferisbarov ceferisbarov deleted the coerce branch April 13, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants