Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings #50

Merged
merged 4 commits into from
Apr 23, 2022
Merged

Update docstrings #50

merged 4 commits into from
Apr 23, 2022

Conversation

ceferisbarov
Copy link
Contributor

Docstrings for the following transforms were updated:

  • Quantile
  • Functional
  • EigenAnalysis / PCA / DRS / SDS
  • Sequential
  • Parallel

Comment on lines 17 to 20
## Notes

* The schema of the table is preserved by the transform.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these notes. We already had this discussion in other PRs. This information is not useful.

Comment on lines 17 to 19
## Notes

* The schema of the table is preserved by the transform.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #50 (acfdd2e) into master (928b8e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          19       19           
  Lines         461      461           
=======================================
  Hits          428      428           
  Misses         33       33           
Impacted Files Coverage Δ
src/transforms/eigenanalysis.jl 79.62% <ø> (ø)
src/transforms/functional.jl 93.75% <ø> (ø)
src/transforms/parallel.jl 91.52% <ø> (ø)
src/transforms/quantile.jl 94.44% <ø> (ø)
src/transforms/sequential.jl 92.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 928b8e5...acfdd2e. Read the comment docs.

@eliascarv eliascarv requested a review from juliohm April 23, 2022 13:43
@juliohm juliohm merged commit e3c8933 into JuliaML:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants