allow LogExpFunctions 0.3 in compat #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also please bump the minor version? |
|
Or patch version? |
|
Yes, patch, I don't know why I wrote minor 🤦 |
|
Done |
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
- Coverage 92.68% 92.61% -0.08%
==========================================
Files 12 12
Lines 2653 2653
==========================================
- Hits 2459 2457 -2
- Misses 194 196 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
KristofferC
added a commit
that referenced
this pull request
Aug 13, 2021
This reverts commit a3b30a9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the only breakage is the removal of some exports in JuliaStats/LogExpFunctions.jl@39223ba
cc @devmotion
Close #333