Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
gamma_inc_inv
as suggested in #374 (review):p + q == 1
and handling of special cases (iszero(p)
andiszero(q)
) are performed without promotionsmin(p, q)
(the PR does not compute
1 - min(p, q)
as in Handle the case when Float64(p) + Float64(q) != 1 in gamma_inc_inv #374)Moreover, the PR
logr
andlog(p)
gamma_inc_inv