Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gamma_inc_inv #377

Merged
merged 5 commits into from
Feb 6, 2022

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Feb 3, 2022

Refactors gamma_inc_inv as suggested in #374 (review):

Moreover, the PR

  • gets rid of redundant computations of logr and log(p)
  • fixes promotion of arguments of gamma_inc_inv

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #377 (b8f3057) into master (9dd5bf8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   92.34%   92.32%   -0.03%     
==========================================
  Files          12       12              
  Lines        2797     2789       -8     
==========================================
- Hits         2583     2575       -8     
  Misses        214      214              
Flag Coverage Δ
unittests 92.32% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/gamma_inc.jl 91.75% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd5bf8...b8f3057. Read the comment docs.

@devmotion devmotion closed this Feb 5, 2022
@devmotion devmotion reopened this Feb 5, 2022
@giordano
Copy link
Member

giordano commented Feb 5, 2022

If you're wondering why CI isn't running: https://www.githubstatus.com/incidents/vvthhf8gxt80

@andreasnoack andreasnoack merged commit 51c5cd6 into JuliaMath:master Feb 6, 2022
@devmotion devmotion deleted the dw/refactor_gamma_inc_inv branch February 6, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants