Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mm_unbalanced function #22

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Conversation

pnavaro
Copy link
Contributor

@pnavaro pnavaro commented Jun 10, 2024

I had to modify the tests because they did not pass.

@pnavaro
Copy link
Contributor Author

pnavaro commented Jun 27, 2024

Dear PythonOT.jl mainteners, could take a look to my PR ?

Cheers

Pierre

Copy link
Member

@davibarreira davibarreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems very straightforward, but there are modifications in the Github workflow, which perhaps should go in another PR?
@devmotion , do you mind taking a look?

@pnavaro
Copy link
Contributor Author

pnavaro commented Jul 5, 2024

The PR seems very straightforward, but there are modifications in the Github workflow, which perhaps should go in another PR? @devmotion , do you mind taking a look?

Indeed I can split it into two Prs.

src/lib.jl Outdated Show resolved Hide resolved
src/lib.jl Outdated Show resolved Hide resolved
src/lib.jl Outdated Show resolved Hide resolved
src/lib.jl Outdated Show resolved Hide resolved
src/lib.jl Outdated Show resolved Hide resolved
src/lib.jl Outdated Show resolved Hide resolved
src/lib.jl Outdated Show resolved Hide resolved
pnavaro and others added 7 commits July 6, 2024 14:27
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (a3c1d24) to head (1ff7c02).

Files Patch % Lines
src/lib.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   86.20%   81.25%   -4.96%     
==========================================
  Files           3        3              
  Lines          29       32       +3     
==========================================
+ Hits           25       26       +1     
- Misses          4        6       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is almost ready, it seems it's only missing a test. Can you add a doctest to the docstring, similar to the other functions (IIRC The examples are at least partly taken from the POT docs)?

@pnavaro
Copy link
Contributor Author

pnavaro commented Jul 10, 2024

Thanks, I added the doctest.

@devmotion
Copy link
Member

Thank you!

@devmotion devmotion merged commit 6510029 into JuliaOptimalTransport:main Jul 10, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants