-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mm_unbalanced function #22
Conversation
Dear PythonOT.jl mainteners, could take a look to my PR ? Cheers Pierre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR seems very straightforward, but there are modifications in the Github workflow, which perhaps should go in another PR?
@devmotion , do you mind taking a look?
Indeed I can split it into two Prs. |
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 86.20% 81.25% -4.96%
==========================================
Files 3 3
Lines 29 32 +3
==========================================
+ Hits 25 26 +1
- Misses 4 6 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is almost ready, it seems it's only missing a test. Can you add a doctest to the docstring, similar to the other functions (IIRC The examples are at least partly taken from the POT docs)?
Thanks, I added the doctest. |
Thank you! |
I had to modify the tests because they did not pass.