DPW visualization

[lassepe]

The D3tree visualization of the DPW includes duplicate state nodes even if check_repeat_state = true is passed. This is due to the fact that the visualization method uses tree.transitions even if tree.unique_transitions is available.

[lassepe]

@zsunberg BTW: I would have expected that detect_repeat = true of D3Trees.jl takes care of this. So maybe there is another bug to fix.

[codecov]

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   83.68%   83.87%   +0.19%     
==========================================
  Files          11       11              
  Lines         423      428       +5     
==========================================
+ Hits          354      359       +5     
  Misses         69       69              

Impacted Files	Coverage Δ
src/visualization.jl	96.70% <100.00%> (+0.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d336772...2a57ed9. Read the comment docs.

[zsunberg]

@zsunberg BTW: I would have expected that detect_repeat = true of D3Trees.jl takes care of this. So maybe there is another bug to fix.

That option is just to keep the D3Tree constructor from getting into an infinite loop if there are cycles, so it is a slightly different concept from detecting whether two children are the same. I think we should allow people to display D3Trees with two child nodes that are the same if they want to for some reason. So we should not fix that.

[zsunberg]

Looks good - thanks!

[zsunberg]

@lassepe do you think we should tag a new bugfix version, or just let this live in master for a while

[lassepe]

@lassepe do you think we should tag a new bugfix version, or just let this live in master for a while

I'm a fan of "tag early and often" but for me this is not urgent. I just came across this bug when using DPW-MCTS for a toy project.

[zsunberg]

Ok, I will wait for CompatHelper to run and then tag a new one. - Zach

…

On Fri, Oct 23, 2020 at 2:49 PM Lasse Peters ***@***.***> wrote: @lassepe <https://github.com/lassepe> do you think we should tag a new bugfix version, or just let this live in master for a while I'm a fan of "tag early and often" but for me this is not urgent. I just came across this bug when using DPW-MCTS for a toy project. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#74 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABALI22KYYHNCEIYV4QOC43SMHT5JANCNFSM4S4R22EQ> .