[Rootfs] Add GCC 11.1 #153
Conversation
| # Ugly hack alert! Because GCC 11 has somehow broken C++, we pair GCC 10 with GCC 11 on MacOS | ||
| if name == "GCCBootstrap" && version.major == 11 && target !== nothing && Sys.islinux(target) | ||
| version = v"10.2.0" | ||
| version = v"11.1.0" |
There was a problem hiding this comment.
I'm not really sure about this, I've never got the point of this if --- I think it was related to the aarch64-apple-darwin GCC?
There was a problem hiding this comment.
I believe what happened here was that I tried building a GCC 11 build targeting x86_64-linux-musl, and then when I targeted aarch64-apple-darwin, I would get GCC 11 for both target and host. Then, when I tried to build stuff targeting the host (e.g. using HOST_CXX) everything was broken with GCC 11. So I made this if statement to force it to give us GCC 11 for aarch64, but GCC 10 for x86_64.
Since you say you were able to run the test suite, it sounds like it's fixed now, so I think we can remove the if statement completely. Thanks!
There was a problem hiding this comment.
Ok, it looks like this is needed to make the aarch64-apple-darwin shell work, otherwise this function wouldn't find a GCCBootstrap with the same version number for the host system. I suspect the comment is just completely misleading?
There was a problem hiding this comment.
Mmm, I think it was actually needed for the reason the comment stated, but the new form looks good to me. Go ahead and update the comment to reflect the new nature of the conditional, and I think we're good to go.
|
I ran |
2 participants
Companion pull request in Yggdrasil: JuliaPackaging/Yggdrasil#3174