Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import unrelease function for fire_task! function #83

Merged
merged 1 commit into from
Mar 22, 2018
Merged

import unrelease function for fire_task! function #83

merged 1 commit into from
Mar 22, 2018

Conversation

tk3369
Copy link
Contributor

@tk3369 tk3369 commented Mar 20, 2018

The cache option is broken due to unrelease not being imported. This PR fixes the issue.

Error from running the cache.jl test.

$ julia cache.jl 
cache: Error During Test
  Test threw an exception of type UndefVarError
  Expression: -s1 == collect(sum2)
  UndefVarError: unrelease not defined
  Stacktrace:
   [1] fire_task!(::Dagger.Context, ::Dagger.Thunk, ::Dagger.OSProc, ::Dagger.Sch.ComputeState, ::Channel{Any}, ::Function) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:127
   [2] compute_dag(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:35
   [3] compute(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:26
   [4] collect(::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:10
   [5] macro expansion at /Users/tomkwong/.julia/v0.6/Dagger/test/cache.jl:18 [inlined]
   [6] macro expansion at ./test.jl:860 [inlined]
   [7] anonymous at ./<missing>:?
cache: Error During Test
  Test threw an exception of type UndefVarError
  Expression: s1 == collect(sum1)
  UndefVarError: unrelease not defined
  Stacktrace:
   [1] fire_task!(::Dagger.Context, ::Dagger.Thunk, ::Dagger.OSProc, ::Dagger.Sch.ComputeState, ::Channel{Any}, ::Function) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:127
   [2] compute_dag(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:35
   [3] compute(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:26
   [4] collect(::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:10
   [5] macro expansion at /Users/tomkwong/.julia/v0.6/Dagger/test/cache.jl:19 [inlined]
   [6] macro expansion at ./test.jl:860 [inlined]
   [7] anonymous at ./<missing>:?
cache: Error During Test
  Test threw an exception of type UndefVarError
  Expression: -(collect(sum1)) == collect(sum2)
  UndefVarError: unrelease not defined
  Stacktrace:
   [1] fire_task!(::Dagger.Context, ::Dagger.Thunk, ::Dagger.OSProc, ::Dagger.Sch.ComputeState, ::Channel{Any}, ::Function) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:127
   [2] compute_dag(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:35
   [3] compute(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:26
   [4] collect(::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:10
   [5] macro expansion at /Users/tomkwong/.julia/v0.6/Dagger/test/cache.jl:20 [inlined]
   [6] macro expansion at ./test.jl:860 [inlined]
   [7] anonymous at ./<missing>:?
cache: Error During Test
  Test threw an exception of type UndefVarError
  Expression: s1 != collect(sum1)
  UndefVarError: unrelease not defined
  Stacktrace:
   [1] fire_task!(::Dagger.Context, ::Dagger.Thunk, ::Dagger.OSProc, ::Dagger.Sch.ComputeState, ::Channel{Any}, ::Function) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:127
   [2] compute_dag(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:35
   [3] compute(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:26
   [4] collect(::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:10
   [5] macro expansion at /Users/tomkwong/.julia/v0.6/Dagger/test/cache.jl:28 [inlined]
   [6] macro expansion at ./test.jl:860 [inlined]
   [7] anonymous at ./<missing>:?
cache: Error During Test
  Test threw an exception of type UndefVarError
  Expression: s2 != collect(sum2)
  UndefVarError: unrelease not defined
  Stacktrace:
   [1] fire_task!(::Dagger.Context, ::Dagger.Thunk, ::Dagger.OSProc, ::Dagger.Sch.ComputeState, ::Channel{Any}, ::Function) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:127
   [2] compute_dag(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/scheduler.jl:35
   [3] compute(::Dagger.Context, ::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:26
   [4] collect(::Dagger.Thunk) at /Users/tomkwong/.julia/v0.6/Dagger/src/compute.jl:10
   [5] macro expansion at /Users/tomkwong/.julia/v0.6/Dagger/test/cache.jl:29 [inlined]
   [6] macro expansion at ./test.jl:860 [inlined]
   [7] anonymous at ./<missing>:?
Test Summary: | Error  Total
cache         |     5      5

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.508% when pulling ad1872c on tk3369:master into d374c77 on JuliaParallel:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.508% when pulling ad1872c on tk3369:master into d374c77 on JuliaParallel:master.

@shashi shashi merged commit e7ca616 into JuliaParallel:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants