Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for [BUG] #3135 mp4/mov animations can't be opened with QuickTime or Safari #3209

Merged
merged 15 commits into from
Jan 5, 2021

Conversation

liasiegelman
Copy link
Contributor

@liasiegelman liasiegelman commented Jan 2, 2021

specifies the codec so that the movie can be opened by QuickTime player

Fix #3135

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #3209 (a209a91) into master (93825e2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3209   +/-   ##
=======================================
  Coverage   65.50%   65.50%           
=======================================
  Files          25       25           
  Lines        6454     6454           
=======================================
  Hits         4228     4228           
  Misses       2226     2226           
Impacted Files Coverage Δ
src/animation.jl 38.20% <0.00%> (ø)
src/backends/pgfplotsx.jl 60.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93825e2...a209a91. Read the comment docs.

@BeastyBlacksmith
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mp4/mov animations can't be opened with QuickTime or Safari
2 participants