Skip to content

Make view return a view of the underlying buffer #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2022
Merged

Make view return a view of the underlying buffer #10

merged 2 commits into from
Mar 5, 2022

Conversation

darsnack
Copy link
Contributor

@darsnack darsnack commented Mar 4, 2022

This adds a custom view that returns a view of the buffer instead of a view of the CircularArrayBuffer (matching the behavior of getindex). This is needed to do zero-copy operations on the buffer while using CUDA.jl.

@findmyway findmyway merged commit 0125375 into JuliaReinforcementLearning:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darsnack @findmyway