Preparation for v0.19

[GearsAD]

This is in preparation for the v0.19 release as we discussed @dehann @Affie.

• Attic has been cleaned out
• Neo4jDFG has been removed
• Tests have been updated

Open question(s) (@Affie)

• Is GraphsDFG different from LightDFG? Can we not merge those?

Regarding downstream the DFG driver we are planning on building out, I believe these functions will be difficult to implement:

• getAddHistory
• getBiadjacencyMatrix
• getInternalId
• findFactorsBetweenNaive
• saveDFG, loadDFG!, loadDFG
• toDot and toDotFile

I suggest we leave this open until we are ready to make v0.19 (no urgency), I just set it up while reviewing the code.

[codecov]

Codecov Report

Merging #918 (7a0c32a) into master (685b5f9) will decrease coverage by 2.63%.
The diff coverage is 70.89%.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   76.06%   73.44%   -2.63%     
==========================================
  Files          38       27      -11     
  Lines        3134     2154     -980     
==========================================
- Hits         2384     1582     -802     
+ Misses        750      572     -178     

Impacted Files	Coverage Δ
src/DFGPlots/DFGPlots.jl	66.66% <ø> (-16.67%)	⬇️
src/Deprecated.jl	28.57% <0.00%> (-0.85%)	⬇️
src/DistributedFactorGraphs.jl	100.00% <ø> (ø)
src/entities/AbstractDFG.jl	100.00% <ø> (ø)
src/services/AbstractDFG.jl	83.45% <33.33%> (-1.90%)	⬇️
src/services/Serialization.jl	65.86% <57.89%> (-6.10%)	⬇️
src/services/DFGFactor.jl	82.60% <66.66%> (-3.76%)	⬇️
src/services/DFGVariable.jl	71.10% <66.66%> (-1.38%)	⬇️
src/entities/DFGFactor.jl	88.00% <91.66%> (+1.79%)	⬆️
src/entities/DFGVariable.jl	88.23% <94.44%> (+4.02%)	⬆️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dehann]

getAddHistory
getBiadjacencyMatrix
getInternalId
findFactorsBetweenNaive
saveDFG, loadDFG!, loadDFG
toDot and toDotFile

All these functions should stay in the abstract interface, and if new drivers are not immediately able to implement them then that is just a limitation of that driver. Other DFG drivers like GraphDFG already implement them so nothing has to change there. Also functions that exist in AbstactDFG only made it there because they were used somewhere. We have very little fat in DFG so to speak.

[dehann]

to make v0.19 (no urgency), I just set it up while reviewing the code

thanks for prepping the PR!

[dehann]

Neo4jDFG has been removed

We should just put Neo4jDFG under a whole new repo and distribute with GPL license? See Stefan K's issue:

• change license to MIT (or GPL)? KernelDensityEstimate.jl#94

[dehann]

Just to help, on master branch i added additional option in if packedProps is no longer a JSON string inside the top level JSONable object:

DistributedFactorGraphs.jl/src/services/Serialization.jl

Lines 348 to 360 in 685b5f9

	smallData = if haskey(packedProps, "smallData")
	if packedProps["smallData"] isa String
	JSON2.read(packedProps["smallData"], Dict{Symbol, SmallDataTypes})
	elseif packedProps["smallData"] isa Dict
	Dict{Symbol, SmallDataTypes}( Symbol.(keys(packedProps["smallData"])) .=> values(packedProps["smallData"]) )
	# packedProps["smallData"]
	else
	@warn "unknown smallData deserialization on $label, type $(typeof(packedProps["smallData"]))" maxlog=10
	Dict{Symbol, SmallDataTypes}()
	end
	else
	Dict{Symbol, SmallDataTypes}()
	end

[dehann]

looks good to me

[GearsAD]

This is the precursor to resolving #590

[GearsAD]

-5,700 lines... yep 🧹 🔥

[dehann]

i had another fix or two to add, and looks good to me. Tests on IIF also pass.