Skip to content

Interpret some constant expressions, fixes #305 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2021

Conversation

chriselrod
Copy link
Member

@chriselrod chriselrod commented Jul 25, 2021

I'll add more accurate determination of register pressure in another commit, probably to this same PR. The associated issue for that is this comment on Zulip.

For now, it just contains the interpretation of some constant expressions, which can sometimes drastically reduce the amount of arguments passed to _turbo_!.

@chriselrod
Copy link
Member Author

Oh, and add vfmaddsub support, which I apparently haven't actually released in VectorizationBase yet.

@chriselrod chriselrod enabled auto-merge (squash) July 25, 2021 22:13
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #306 (1fc3177) into master (95ba84d) will decrease coverage by 0.76%.
The diff coverage is 86.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   89.51%   88.74%   -0.77%     
==========================================
  Files          37       37              
  Lines        8057     8184     +127     
==========================================
+ Hits         7212     7263      +51     
- Misses        845      921      +76     
Impacted Files Coverage Δ
src/LoopVectorization.jl 100.00% <ø> (ø)
src/modeling/costs.jl 67.58% <ø> (-0.47%) ⬇️
src/modeling/operations.jl 90.69% <0.00%> (-1.43%) ⬇️
src/codegen/lower_constant.jl 72.91% <38.63%> (-10.20%) ⬇️
src/modeling/graphs.jl 87.59% <82.25%> (-0.95%) ⬇️
src/codegen/loopstartstopmanager.jl 87.92% <87.50%> (-0.79%) ⬇️
src/parse/add_compute.jl 96.83% <93.33%> (-0.41%) ⬇️
src/codegen/lowering.jl 89.29% <95.23%> (-2.23%) ⬇️
src/modeling/determinestrategy.jl 96.14% <96.47%> (+0.02%) ⬆️
src/codegen/lower_store.jl 94.47% <100.00%> (-0.06%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ba84d...1fc3177. Read the comment docs.

@chriselrod chriselrod merged commit 3b7344c into master Jul 26, 2021
@chriselrod chriselrod deleted the interpretconstsmoreaccurateregpress branch July 26, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant