cholmod: correct the IndexStyle method additions
#650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the methods in question can be simply deleted because `IndexCartesian` is the default. The other one is changed to be defined on the type instead of on the instance, as intended. Preventing defining `IndexStyle` methods on instances (as opposed to types) prevents a single invalidation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 84.02% 84.02% -0.01%
==========================================
Files 12 12
Lines 9298 9297 -1
==========================================
- Hits 7813 7812 -1
Misses 1485 1485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nsajko
changed the title
IndexStyle method additionsIndexStyle method additions
nsajko
changed the title
IndexStyle method additionsIndexStyle method additions
rayegun
approved these changes
Sep 14, 2025
KristofferC
pushed a commit
that referenced
this pull request
Sep 22, 2025
(cherry picked from commit 306605d)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the methods in question can be simply deleted because
IndexCartesianis the default.The other one is changed to be defined on the type instead of on the instance, as intended.
Preventing defining
IndexStylemethods on instances (as opposed to types) prevents a single invalidation.