Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecation of not giving dims #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

KristofferC
Copy link
Member

I missed this change. This is really annoying to have to specify. It is clearly documented how we interpret a matrix.

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, the whole point of the deprecation was to stop using dims=2 as a silent default, since it goes against what e.g. cov does (see #121). If you remove the deprecation and go back to dims=2, the inconsistency is back again.

@@ -105,12 +105,12 @@ matrices with observations stored in rows are also supported via the argument `d

#### Computing column-wise and pairwise distances inplace

If the vector/matrix to store the results are pre-allocated, you may use the storage (without creating a new array) using the following syntax (`i` being either `1` or `2`):
If the vector/matrix to store the results are pre-allocated, you may use the storage (without creating a new array) using the following syntax (`dims` being either `1` or `2`):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need to specify dims here now, it was just required due to the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants