-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algorithm AS 176 for KDE's #29
Conversation
I've fixed the scaling problem, which was caused by an inaccurate calculation of the original histogram that gets convolved with the kernel. Still working on the interlacing problem. |
It would be great if someone with more familiarity with FFT's got a chance to look at this. I suspect I've made a simple mistake. |
fix tests: Multinomial is immutable
Fixes for kde
Alternate definition of mean, variance for Categorical distribution.
Add travis configuration
Conflicts: src/Distributions.jl
This looks like it basically works now thanks to @simonbyrne's patch. I think the actual bandwidth being used is more extreme than R's, though, which leads to some oversmoothing. |
Algorithm AS 176 for KDE's
Here's the start of an alternative KDE implementation:
This code needs to get cleaned up, but it should provide a faster way to compute KDE's with Gaussian kernels than the more general purpose code currently being discussed.
There are two major bugs right now:
I'll try to finish this over the next few days, but wanted to get the draft code out there for comparison with Jameson's approach -- which will probably be complete much sooner than this code will be.