Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FastText links #23

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Update FastText links #23

merged 1 commit into from
Nov 17, 2019

Conversation

Ayushk4
Copy link
Member

@Ayushk4 Ayushk4 commented Nov 3, 2019

The previous links to fasttext weren't working, so the newer ones on fasttext's website have been added here.

@oxinabox
Copy link
Member

oxinabox commented Nov 3, 2019

Why is CI failing?

@Ayushk4
Copy link
Member Author

Ayushk4 commented Nov 4, 2019

Something to do with GloVe embeddings. I am looking into it and will get back to you.

@oxinabox
Copy link
Member

breaking for same reason as #24 I suspect?

@Ayushk4
Copy link
Member Author

Ayushk4 commented Nov 13, 2019

breaking for same reason as #24 I suspect?

I don't think so.

It's giving this error - No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. during the execution of GloVe testsets.

For 0.7 (apple's osx) it's giving error outside of test in this line -

glove = load_embeddings(GloVe{:en}, @datadep_str(file), max_vocab_size=1000)

and in this next testset "Specific" on line 89.

The tests are failing for Embeddings.jl#master - (Here's a pr sent to my own fork that changes nothing in the codebase and it's failing.) Ayushk4#1

@oxinabox oxinabox mentioned this pull request Nov 15, 2019
@oxinabox
Copy link
Member

I am going to merge this now and will fix any issues in #27

@oxinabox oxinabox merged commit 1cb2401 into JuliaText:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants