New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenize begins with full stop. #28

Closed

haampie opened this issue Jun 18, 2019 · 1 comment

haampie commented Jun 18, 2019

tokenize("hello world.")
3-element Array{String,1}:
 "."    
 "hello"
 "world"

Shouldn't this return ["hello", "world", "."]?

The text was updated successfully, but these errors were encountered:

Member

oxinabox commented Jun 18, 2019 •

edited

Loading

Hmm how did the tests miss this?
Bug is in https://github.com/JuliaText/WordTokenizers.jl/blob/master/src/words/TokTok.jl#L118
(And again later in that function)
That function should not flush.
It should return the final character(s).
To be flushed at the end.

PR would be appreciated

Ayushk4 mentioned this issue

Fix TokTok.jl #29

Merged

oxinabox closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment